Fix leading-underscore rule for constant variables #5573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Already covered by #5497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX
Description
This PR implements the TODO in the solhint-custom/index.js file to expand the leading-underscore rule for constant variables. The rule now checks all constant variables regardless of their visibility, not just private ones.
Previously, the rule only checked private constant variables for leading underscores, but according to the coding standards, no constant variables should have leading underscores regardless of their visibility.
Changes
leading-underscorerule inscripts/solhint-custom/index.jsto check all constant variables for leading underscores, not just private onesPR Checklist
npx changeset add)